This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
Convert rake acceptance tests to specs #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sodabrew I don't suppose you want to finish this up? :) |
|
I looked a bit around how to best test rake tasks. The most common suggestion was to simply move the code into a class and test that class. I think this will require some major refactoring as there is quite a lot of code in the rake tasks itself. I opened a new issue #379 for this and I'm closing this PR for now. If you suddenly feel the urge to continue the work here feel free to reopen it 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incomplete conversion, just getting started on this.