nixosModules.monitoring: enable nginx and add tests #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `mkDefault` for enable flags for easier toggling. Co-authored-by: Robert James Hernandez <[email protected]>
This is always going to be localhost. Co-authored-by: Robert James Hernandez <[email protected]>
Create an option for the hostname header to be routed to the grafana service. `proxyWebsockets` option got moved since this was created. Co-authored-by: Robert James Hernandez <[email protected]>
Co-authored-by: Robert James Hernandez <[email protected]>
djacu
requested review from
jshcmpbll,
owendelong,
kylerisse and
sarcasticadmin
sarcasticadmin
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Worked with @djacu on getting nginx configured with grafana. This doesnt enable TLS yet but leveraging routing from the header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Use
mkDefaultfor enable flags for easier toggling.Remove
grafanaDomainoption and inlinelocalhost.Enable nginx routing and fix module definition.
Add test to check routing for grafana.
Previous Behavior
We didn't enable nginx for monitoring.
New Behavior
We enabled nginx for monitoring.
Tests
nix build .#checks.x86_64-linux.monitor