Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to @snyk #1255

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Move to @snyk #1255

merged 1 commit into from
Dec 6, 2021

Conversation

eliecharra
Copy link
Contributor

No description provided.

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Dec 6, 2021
@eliecharra eliecharra requested a review from a team as a code owner December 6, 2021 13:30
@CLAassistant
Copy link

CLAassistant commented Dec 6, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

craigfurman
craigfurman approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@craigfurman craigfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I paged through this diff pretty quickly, so might have missed something, but looks good.

Non-blocking note: there are references to cloudskiff/driftctl left in various places. We should probably grep for them and fix them. I'll leave it up to you whether or not to do it here or in a follow-on, as this PR is a potential merge conflict bomb, and we want to merge it soon 😁

@eliecharra
Copy link
Contributor Author

Non-blocking note: there are references to cloudskiff/driftctl left in various places. We should probably grep for them and fix them. I'll leave it up to you whether or not to do it here or in a follow-on, as this PR is a potential merge conflict bomb, and we want to merge it soon

Yeah let's do that in another PR, this PR is a merge 💣 as you said so let's merge it quickly.

Thanks a lot for your eye on this one 🙏🏻

@eliecharra eliecharra merged commit 233b788 into main Dec 6, 2021
@eliecharra eliecharra deleted the move_to_snyk branch December 6, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigfurman craigfurman craigfurman approved these changes

@sundowndev sundowndev sundowndev approved these changes

@moadibfr moadibfr Awaiting requested review from moadibfr

@wbeuil wbeuil Awaiting requested review from wbeuil

Assignees
No one assigned
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eliecharra @CLAassistant @craigfurman @sundowndev