-
Notifications
You must be signed in to change notification settings - Fork 627
fix: support using sarif and json output files at the same time #5985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support using sarif and json output files at the same time #5985
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
|
4a42fd8
to
38b9327
Compare
d8d4373
to
c2b9fdc
Compare
217f0f9
to
5e6bfd0
Compare
5e6bfd0
to
4ec7238
Compare
4ec7238
to
7f28efa
Compare
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR changes the behaviour of the golang native
code test
implementation to match the typescript implementation with regards to output file handling.--sarif-file-output
and--json-file-output
.--sarif-file-output
but doesn't create a file for--json-file-output
.Where should the reviewer start?
The main changes can be found in this GAF PR.
This PR also adds user journey tests for both cases and adapt the output configuration based on the new options.
How should this be manually tested?
Using
--json-file-output
and--sarif-file-output
for code scans with CCI enabled should create two files like the parameters would specify. This can be compared to the old behaviour where only one file was being created.What's the product update that needs to be communicated to CLI users?
--sarif-file-output
and--json-file-output
.--sarif-file-output
but doesn't create a file for--json-file-output
.Risk assessment (Low | Medium | High)?
The Risk of the change is Low as it affects the rendering engine currently only used for CCI for which we have a good test coverage.
Ref: CLI-860
Ref: CLI-980