SNOW-1932729: Add logging messages to snowpark-checkpoints-collectors #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fgonzalezmendez
changed the title
sfc-gh-fgonzalezmendez
force-pushed
the
feature/SNOW-1932729
branch
11 times, most recently
from
e0d263a to
73a553a
Compare
sfc-gh-fgonzalezmendez
changed the title
sfc-gh-fgonzalezmendez
changed the title
sfc-gh-fgonzalezmendez
requested review from
sfc-gh-lbravozuniga and
sfc-gh-dchaconbarrantes
sfc-gh-lbravozuniga
approved these changes
Feb 20, 2025
...eckpoints-collectors/src/snowflake/snowpark_checkpoints_collector/summary_stats_collector.py
Outdated
Show resolved
Hide resolved
...rk-checkpoints-collectors/src/snowflake/snowpark_checkpoints_collector/utils/extra_config.py
Show resolved
Hide resolved
sfc-gh-lbravozuniga
approved these changes
Feb 28, 2025
sfc-gh-fgonzalezmendez
force-pushed
the
feature/SNOW-1932729
branch
from
b663f00 to
4d8e4e4
Compare
...s/src/snowflake/snowpark_checkpoints_collector/column_collection/column_collector_manager.py
Show resolved
Hide resolved
sfc-gh-lbravozuniga
approved these changes
Mar 5, 2025
...rk-checkpoints-collectors/src/snowflake/snowpark_checkpoints_collector/utils/extra_config.py
Show resolved
Hide resolved
sfc-gh-dchaconbarrantes
requested changes
Mar 7, 2025
|
|
||
| if not is_checkpoint_enabled(normalized_checkpoint_name): | ||
| LOGGER.info( | ||
| "Checkpoint '%s' is disabled. Skipping collection.", checkpoint_name |
There was a problem hiding this comment.
Suggested change
| "Checkpoint '%s' is disabled. Skipping collection.", checkpoint_name | |
| "Checkpoint '%s' is disabled. Skipping collection.", normalized_checkpoint_name |
Should we used normalized_checkpoint_name instead checkpoint_name?
There was a problem hiding this comment.
Fixed in commit 421a9dd
| ) | ||
| collection_point_result_manager.add_result(collection_point_result) | ||
| collection_point_result.result = CollectionResult.PASS | ||
| LOGGER.info("Checkpoint '%s' collected successfully", checkpoint_name) |
There was a problem hiding this comment.
Suggested change
| LOGGER.info("Checkpoint '%s' collected successfully", checkpoint_name) | |
| LOGGER.info("Checkpoint '%s' collected successfully", normalized_checkpoint_name) |
Also here
There was a problem hiding this comment.
Fixed in commit 421a9dd
|
|
||
| except Exception as err: | ||
| collection_point_result.result = CollectionResult.FAIL | ||
| error_message = str(err) |
There was a problem hiding this comment.
Do we report failed checkpoints in another catch or do we have to add it?
There was a problem hiding this comment.
I think it is not necessary. The exception raised by this except block will be caught by the log decorator. Any exception caught by the log decorator means that the collection failed.
| raise Exception("No parquet files were generated.") | ||
| LOGGER.info( | ||
| "Wrote %s parquet files at '%s'", |
There was a problem hiding this comment.
Suggested change
| "Wrote %s parquet files at '%s'", | |
| "%s parquet files were written in '%s'", |
There was a problem hiding this comment.
Fixed in commit 421a9dd
sfc-gh-fgonzalezmendez
force-pushed
the
feature/SNOW-1932729
branch
from
7a72f49 to
421a9dd
Compare
sfc-gh-fgonzalezmendez
force-pushed
the
feature/SNOW-1932729
branch
from
421a9dd to
37d3840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Context
JIRA: SNOW-1932729
Description
This pull request introduces logging messages across multiple modules of the
snowpark-checkpoints-collectorspackage. This messages aim to enhance the debugging and monitoring capabilities of the package.How Has This Been Tested?
Checklist
Review & Approval Requests
Note: Use GitHub's draft PR feature instead of tagging a PR as
DO NOT MERGE.