feat: Add logging

snok · Jul 11, 2024 · 502af53 · 502af53
1 parent 5996d71
commit 502af53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/cli/args.rs b/src/cli/args.rs
@@ -40,7 +40,7 @@ pub fn try_parse_shas_as_list(s: &str) -> Result<Vec<String>, String> {
     Ok(shas)
 }
 
-fn try_parse_url(url_str: &str) -> Result<Url, url::ParseError> {
+pub(crate) fn try_parse_url(url_str: &str) -> Result<Url, url::ParseError> {
     // Since `Url` will always add a `/` if the path is empty, we should make it consistent beforehand.
     // See also: https://github.com/servo/rust-url/issues/808
     if url_str.ends_with('/') {

diff --git a/src/main.rs b/src/main.rs
@@ -10,7 +10,7 @@ use tracing_subscriber::layer::SubscriberExt;
 use tracing_subscriber::util::SubscriberInitExt;
 use tracing_subscriber::{fmt, EnvFilter};
 
-use crate::cli::args::{Input, DEFAULT_GITHUB_API_URL, DEFAULT_GITHUB_SERVER_URL};
+use crate::cli::args::{try_parse_url, Input, DEFAULT_GITHUB_API_URL, DEFAULT_GITHUB_SERVER_URL};
 use crate::client::builder::PackagesClientBuilder;
 use crate::client::client::PackagesClient;
 use crate::client::models::PackageVersion;
@@ -77,10 +77,10 @@ async fn main() -> Result<()> {
     let init_span = info_span!("parse input").entered();
     let input = Input::parse();
 
-    if input.github_server_url.as_str() != DEFAULT_GITHUB_SERVER_URL {
+    if input.github_server_url != try_parse_url(DEFAULT_GITHUB_SERVER_URL).expect("URL parse error") {
         info!("Using provided GitHub server url: {}", input.github_server_url);
     }
-    if input.github_api_url.as_str() != DEFAULT_GITHUB_API_URL {
+    if input.github_api_url != try_parse_url(DEFAULT_GITHUB_API_URL).expect("URL parse error") {
         info!("Using provided GitHub API url: {}", input.github_api_url);
     }