Remove unneeded eager loading for user show page #16520
Merged
+12
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some unneeded related model loading for the user show page.
Most of the tables on the user show page are loaded via the api so we don't need to pass through
assets
,assets.model
, oruserlog.item
.When attempting to view a user with a lot of previous activity, the
$user->userlog->load('item')
line could potentially end up causing a memory exhaustion exception.