Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/tcp panic unrecovered blocking port fix #25

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ddelnano
Copy link
Collaborator

No description provided.

@hcliff
Copy link

hcliff commented Apr 24, 2017

nice, definitely like the move into Run() of the blocking operation, makes sense.
Not sure about the for loop, don't we want to bail out in either the user killing the server or the server erroring? at any rate we issue the os.Exit. lmk if I missed something though

@ddelnano
Copy link
Collaborator Author

@hcliff I added that because I had issues with the signal handling code cleaning up after itself. Unfortunately when I wrote that existing code it was very had to get "right" (despite you saying you have issues with it). But if its really broken then the e2e tests fail which is what I am seeing on my branch now. I will try to give it a look this week. Thanks for giving this a shot. This main binary is a mess and really needs some loving. Hopefully this will be a good start.

@hcliff
Copy link

hcliff commented Apr 24, 2017

It's definitely tricky haha, after using my PR version locally for a couple of weeks I've found there's still a case where if the user kills dredd rapidly after starting a process is left running. (Pretty sure it's during that 100ms wait for the cmd to start running if you're digging into it).

@ddelnano
Copy link
Collaborator Author

@hcliff yea I know 🙈 . Cool thanks for the tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants