Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save initial condition (for movie) #42

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Save initial condition (for movie) #42

merged 1 commit into from
Nov 17, 2022

Conversation

paugier
Copy link
Collaborator

@paugier paugier commented Nov 17, 2022

Fixes #41

For this PR, I will need a real review! :-)

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 61.42% // Head: 61.42% // No change to project coverage 👍

Coverage data is based on head (08961c1) compared to base (17d4932).
Patch has no changes to coverable lines.

❗ Current head 08961c1 differs from pull request most recent head 9583d63. Consider uploading reports for the commit 9583d63 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   61.42%   61.42%           
=======================================
  Files           9        9           
  Lines         534      534           
=======================================
  Hits          328      328           
  Misses        206      206           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashwinvis
Copy link
Member

You also need

  include 'CHKPOINTD'  ! chpt_ifrst

In userchk. Otherwise LGTM

@akhoubani
Copy link
Contributor

As @ashwinvis mentioned, because we are using chpt_ifrst after call frame_end, we need to include 'CHKPOINTD'. Another possibility would be

if (istep .eq. 0 .and. (chpt_ifrst == 0) ) then
      ! first timestep which is not restarted
         call outpost(vx, vy, vz, pr, t, '   ')  ! write initial condition
      ! finalise framework
else if (istep.eq.nsteps.or.lastep.eq.1) then
         call frame_end
endif

@paugier paugier merged commit b426154 into main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save initial condition for movie
3 participants