Skip to content

fix: initializing self.slurm_logdir #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix: initializing self.slurm_logdir #206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76e0b8d
fix: setting slurm_logdir in post_init, else starts without something…
cmeesters Jan 23, 2025
fc4863d
Merge branch 'main' into fix/no_job_logdir
cmeesters Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions snakemake_executor_plugin_slurm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,11 @@ def __post_init__(self):
self._fallback_account_arg = None
self._fallback_partition = None
self._preemption_warning = False # no preemption warning has been issued
self.slurm_logdir = None
self.slurm_logdir = (
Path(self.workflow.executor_settings.logdir)
if self.workflow.executor_settings.logdir
else Path(".snakemake/slurm_logs").resolve()
)
atexit.register(self.clean_old_logs)

def clean_old_logs(self) -> None:
Expand Down Expand Up @@ -180,12 +184,6 @@ def run_job(self, job: JobExecutorInterface):
except AttributeError:
wildcard_str = ""

self.slurm_logdir = (
Path(self.workflow.executor_settings.logdir)
if self.workflow.executor_settings.logdir
else Path(".snakemake/slurm_logs").resolve()
)

self.slurm_logdir.mkdir(parents=True, exist_ok=True)
slurm_logfile = self.slurm_logdir / group_or_rule / wildcard_str / "%j.log"
slurm_logfile.parent.mkdir(parents=True, exist_ok=True)
Expand Down
Loading