feat: STS web identity creds resolver #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
commented
Jun 3, 2025
| @@ -36,6 +36,7 @@ private const val GIT_REPO = "gitRepo" | |||
| private const val SWIFT_VERSION = "swiftVersion" | |||
There was a problem hiding this comment.
The visibility setting in swift plugin codegen settings comes from the smithy-build.json generated at build time by aws-sdk-swift/codegen/sdk-codegen/build.gradle.kts, like all other values in the settings.
It's added to generate an internal STS client into AWSSDKIdentity module. For all public services, visibility is public.
jbelkins
reviewed
Jun 3, 2025
...rc/main/kotlin/software/amazon/smithy/swift/codegen/integration/HttpProtocolServiceClient.kt
Show resolved
Hide resolved
added 3 commits
June 3, 2025 15:24
…nal even when service isn't rules-based, if service client visibility is internal.
added 6 commits
June 10, 2025 14:30
…into auth options returned by auth scheme resolver.
…option append function if it's noAuth.
…mization w/ internal service clients for protocol test codegen.
jbelkins
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR:
Issue #
2380
Description of changes
IdentityProvidingSTSClientto auth option'sidentityProperties, which is then used by relevant cred resolvers during identity resolution.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.