Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServiceShape as the container for operations and rename Shapes to Schema #276

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Use ServiceShape as the container for operations and rename Shapes to Schema #276

merged 4 commits into from
Feb 17, 2025

Conversation

mullermp
Copy link
Contributor

This change does the following refactor:

  • Service shape will be the container object for runtime shapes instead of a Schema object.
  • shapes.rb has been renamed to schema.rb

jterapin
jterapin approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@jterapin jterapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mullermp mullermp merged commit c32b7c0 into decaf Feb 17, 2025
8 checks passed
@mullermp mullermp deleted the schema-refactor branch February 17, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jterapin jterapin jterapin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @jterapin