Generate specs for protocol tests #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Diffing against cbor protocol branch.
Generates protocol tests. Full support for request, response and error tests. Most test code follows the patterns of codegen protocol test from java smithy-ruby.
Steps to run tests:
Run the new
smithy:spec:protocolscommand (or runsmithy:specto do everything)Steps for manually testing
To generate protocol tests:
Then to run them, from your IDE open up the
build/smithy/source/smithy-rubydirectory and run the tests frombuild/smithy/source/smithy-ruby/spec/rpcv2cbor/protocol_spec.rbBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.