Flatten shapes when fetching with Model.shape (#269)

Rakefile

@@ -59,19 +59,27 @@ namespace :smithy do
 
   desc 'Convert all fixture smithy models to JSON AST representation.'
   task 'sync-fixtures' do
+    smithy_build_files = Dir.glob('gems/smithy/spec/fixtures/**/smithy-build.json')
     Dir.glob('gems/smithy/spec/fixtures/**/model.smithy') do |model_path|
       out_path = model_path.sub('.smithy', '.json')
-      sh("smithy ast --aut #{model_path} > #{out_path}")
+      config_files = smithy_build_files.map do |file|
+        " --config #{file}" if model_path.include?(File.dirname(file))
+      end
+      sh("smithy ast#{config_files.join(' ')} #{model_path} > #{out_path}")
     end
   end
 
   desc 'Validate that all fixtures JSON models are up to date.'
   task 'validate-fixtures' do
     require 'json'
     failures = []
+    smithy_build_files = Dir.glob('gems/smithy/spec/fixtures/**/smithy-build.json')
     Dir.glob('gems/smithy/spec/fixtures/**/model.smithy') do |model_path|
       old = JSON.load_file(model_path.sub('.smithy', '.json'))
-      new = JSON.parse(`smithy ast --aut #{model_path}`)
+      config_files = smithy_build_files.map do |file|
+        " --config #{file}" if model_path.include?(File.dirname(file))
+      end
+      new = JSON.parse(`smithy ast#{config_files.join(' ')} #{model_path}`)
       failures << model_path if old != new
     end
     if failures.any?

gems/smithy-client/spec/smithy-client/param_validator_spec.rb

@@ -20,11 +20,7 @@ def validate(params, expected_errors = [])
       def match_errors(error, expected_errors)
         expected_errors = [expected_errors] unless expected_errors.is_a?(Array)
         expected_errors.each do |expected_error|
-          if expected_error.is_a?(String)
-            expect(error.message).to include(expected_error)
-          else
-            expect(error.message).to match(expected_error)
-          end
+          expect(error.message).to include(expected_error)
         end
       end
 

gems/smithy/lib/smithy/model.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative 'model/flattener'
 require_relative 'model/rbs'
 require_relative 'model/shape'
 require_relative 'model/operation_parser'
@@ -37,15 +38,15 @@ module Model
     }.freeze
 
     # @param [Hash] model Model
-    # @param [String] target Target shape
-    # @return [Hash] The shape
-    def self.shape(model, target)
-      if model['shapes'].key?(target)
-        model['shapes'][target]
-      elsif PRELUDE_SHAPES.key?(target)
-        PRELUDE_SHAPES[target]
+    # @param [String] id Shape ID
+    # @return [Hash]
+    def self.shape(model, id)
+      if model['shapes'].key?(id)
+        Flattener.new(model).shape(id)
+      elsif PRELUDE_SHAPES.key?(id)
+        PRELUDE_SHAPES[id]
       else
-        raise ArgumentError, "Shape not found: #{target}"
+        raise ArgumentError, "Shape not found: #{id}"
       end
     end
   end

gems/smithy/lib/smithy/model/flattener.rb

@@ -0,0 +1,114 @@
+# frozen_string_literal: true
+
+module Smithy
+  module Model
+    # @api private
+    class Flattener
+      def initialize(model)
+        @model = model
+      end
+
+      def shape(id)
+        shape = @model['shapes'][id]
+        return shape unless shape['mixins']
+
+        shape['mixins'].reverse_each do |mixin|
+          mixin_shape = shape(mixin['target'])
+          shape = deep_merge(mixin_shape, shape, exclude_traits(mixin_shape))
+          apply_traits(id, shape)
+          shape.delete('mixins')
+        end
+
+        shape
+      end
+
+      private
+
+      def exclude_traits(shape)
+        [
+          'smithy.api#mixin',
+          *shape.fetch('traits', {}).fetch('smithy.api#mixin', {}).fetch('localTraits', [])
+        ]
+      end
+
+      def deep_merge(hash1, hash2, exclude_traits = [], context = nil)
+        hash1 = hash1.dup
+        if hash1['traits']
+          hash1['traits'] = hash1['traits'].except(*exclude_traits)
+          hash1.delete('traits') if hash1['traits'].empty?
+        end
+        deep_merge!(hash1, hash2, exclude_traits, context)
+      end
+
+      def deep_merge!(hash1, hash2, exclude_traits, context)
+        hash1.merge!(hash2) do |key, v1, v2|
+          if v1.is_a?(Hash) && v2.is_a?(Hash)
+            deep_merge(v1, v2, exclude_traits, key)
+          elsif v1.is_a?(Array) && v2.is_a?(Array) && context != 'traits'
+            # Merge arrays, but only if the key is not a trait
+            v1 + v2
+          else
+            v2
+          end
+        end
+      end
+
+      def apply_traits(id, shape)
+        case shape['type']
+        when 'structure'
+          structure(id, shape)
+        when 'union'
+          union(id, shape)
+        when 'list'
+          list(id, shape)
+        when 'map'
+          map_key(id, shape)
+          map_value(id, shape)
+        end
+      end
+
+      def structure(id, shape)
+        shape['members'].each do |member_name, member_shape|
+          member_id = "#{id}$#{member_name}"
+          next unless apply_shape_exists?(member_id)
+
+          apply_shape = shape(member_id)
+          member_keys = shape['members'][member_name].keys
+          shape['members'][member_name] = deep_merge(member_shape, apply_shape).slice(*member_keys)
+        end
+      end
+      alias union structure
+
+      def list(id, shape)
+        member_id = "#{id}$member"
+        return unless apply_shape_exists?(member_id)
+
+        apply_shape = shape(member_id)
+        member_keys = shape['member'].keys
+        shape['member'] = deep_merge(shape['member'], apply_shape).slice(*member_keys)
+      end
+
+      def map_key(id, shape)
+        key_id = "#{id}$key"
+        return unless apply_shape_exists?(key_id)
+
+        key_shape = shape(key_id)
+        key_keys = shape['key'].keys
+        shape['key'] = deep_merge(shape['key'], key_shape).slice(*key_keys)
+      end
+
+      def map_value(id, shape)
+        value_id = "#{id}$value"
+        return unless apply_shape_exists?(value_id)
+
+        value_shape = shape(value_id)
+        value_keys = shape['value'].keys
+        shape['value'] = deep_merge(shape['value'], value_shape).slice(*value_keys)
+      end
+
+      def apply_shape_exists?(id)
+        @model['shapes'][id] && @model['shapes'][id]['type'] == 'apply'
+      end
+    end
+  end
+end