Open
Conversation
smithfarm
reviewed
Nov 1, 2017
| ## | ||
|
|
||
| =over | ||
|
|
Owner
There was a problem hiding this comment.
@manwar Thanks for contributing. I guess you ran these files through podchecker? (Good idea!)
In this case, I'd rather have the commented-out =item be included in the =over . . . =back block. Instead of moving it up like you did, could you move it down to the end of the list (i.e. between "Components") and =back)? That should make podchecker happy.
smithfarm
reviewed
Nov 1, 2017
| # | ||
|
|
||
| =over | ||
|
|
smithfarm
reviewed
Nov 1, 2017
| This will work only if nothing in the database refers to this activity. | ||
|
|
||
| =back | ||
|
|
Owner
There was a problem hiding this comment.
The usefulness of running podchecker on ResourceDefs.pm is debatable, since this file contains incomplete snippets of POD that are concatenated together to make this: https://st.aticpan.org/source/SMITHFARM/App-Dochazka-REST-0.554/lib/App/Dochazka/REST/Docs/Resources.pm
Author
|
Done as requested :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @smithfarm
Please review the PR.
Many Thanks.
Best Regards,
Mohammad S Anwar