feat: LSP support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to sort out configuring which LSP to run rather than hard coding to rust analyzer and the ad codebase but this is now a working (very) minimal client. It looks like rust-analyzer needs to receiver a first request for something before it will index the workspace so that needs to be sorted out and there is a lot of cleanup to do around error handling etc
|
There are still a fair amount of things to add beyond this (most importantly, the ability configure different LSP servers) but I'm aiming on merging the current state as it is in order to have a starting point rather than chasing down every remaining feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some discussion around this in #46
This is very definitely not aiming to provide support for all LSP features (nor is there any plan to do so in the future). Instead it is an attempt to support a useful subset of some of the more basic features of LSP that fit within the existing editing model of
ad. This initial PR is not aiming to implement everything that is called out as in scope below but it should hopefully provide a reasonable starting point.In scope:
Explicitly out of scope:
LSP features not called out above may be considered in the future but not at this time.
ad-lsp-demo-2024-11-30_19.02.13.mp4