Skip to content

feat: UI overhaul

feat: UI overhaul #153

Triggered via pull request October 26, 2024 15:12
@sminezsminez
synchronize #40
ui-overhaul
Status Success
Total duration 53s
Artifacts

rust.yml

on: pull_request
Ensure rustfmt is happy
14s
Ensure rustfmt is happy
Lint the codebase with clippy
34s
Lint the codebase with clippy
Check doc links are valid
22s
Check doc links are valid
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

6 warnings
this `else { if .. }` block can be collapsed: src/ui/windows.rs#L349
warning: this `else { if .. }` block can be collapsed --> src/ui/windows.rs:349:16 | 349 | } else { | ________________^ 350 | | if self.cols.focus.wins.len() == 1 { 351 | | let win = self.cols.remove_focused_unchecked().wins.focus; 352 | | self.cols.focus.wins.insert(win); ... | 357 | | } 358 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if help: collapse nested if block | 349 ~ } else if self.cols.focus.wins.len() == 1 { 350 + let win = self.cols.remove_focused_unchecked().wins.focus; 351 + self.cols.focus.wins.insert(win); 352 + } else { 353 + let win = self.cols.focus.wins.remove_focused_unchecked(); 354 + self.cols.focus_down(); 355 + self.cols.focus.wins.insert(win); 356 + } |
this `else { if .. }` block can be collapsed: src/ui/windows.rs#L319
warning: this `else { if .. }` block can be collapsed --> src/ui/windows.rs:319:16 | 319 | } else { | ________________^ 320 | | if self.cols.focus.wins.len() == 1 { 321 | | let on_left = self.cols.up.is_empty(); 322 | | let win = self.cols.remove_focused_unchecked().wins.focus; ... | 331 | | } 332 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if note: the lint level is defined here --> src/lib.rs:5:5 | 5 | clippy::style, | ^^^^^^^^^^^^^ = note: `#[warn(clippy::collapsible_else_if)]` implied by `#[warn(clippy::style)]` help: collapse nested if block | 319 ~ } else if self.cols.focus.wins.len() == 1 { 320 + let on_left = self.cols.up.is_empty(); 321 + let win = self.cols.remove_focused_unchecked().wins.focus; 322 + if !on_left { 323 + self.cols.focus_up(); 324 + } 325 + self.cols.focus.wins.insert(win); 326 + } else { 327 + let win = self.cols.focus.wins.remove_focused_unchecked(); 328 + self.cols.focus_up(); 329 + self.cols.focus.wins.insert(win); 330 + } |
this `else { if .. }` block can be collapsed: src/ui/windows.rs#L349
warning: this `else { if .. }` block can be collapsed --> src/ui/windows.rs:349:16 | 349 | } else { | ________________^ 350 | | if self.cols.focus.wins.len() == 1 { 351 | | let win = self.cols.remove_focused_unchecked().wins.focus; 352 | | self.cols.focus.wins.insert(win); ... | 357 | | } 358 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if help: collapse nested if block | 349 ~ } else if self.cols.focus.wins.len() == 1 { 350 + let win = self.cols.remove_focused_unchecked().wins.focus; 351 + self.cols.focus.wins.insert(win); 352 + } else { 353 + let win = self.cols.focus.wins.remove_focused_unchecked(); 354 + self.cols.focus_down(); 355 + self.cols.focus.wins.insert(win); 356 + } |
this `else { if .. }` block can be collapsed: src/ui/windows.rs#L319
warning: this `else { if .. }` block can be collapsed --> src/ui/windows.rs:319:16 | 319 | } else { | ________________^ 320 | | if self.cols.focus.wins.len() == 1 { 321 | | let on_left = self.cols.up.is_empty(); 322 | | let win = self.cols.remove_focused_unchecked().wins.focus; ... | 331 | | } 332 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if note: the lint level is defined here --> src/lib.rs:5:5 | 5 | clippy::style, | ^^^^^^^^^^^^^ = note: `#[warn(clippy::collapsible_else_if)]` implied by `#[warn(clippy::style)]` help: collapse nested if block | 319 ~ } else if self.cols.focus.wins.len() == 1 { 320 + let on_left = self.cols.up.is_empty(); 321 + let win = self.cols.remove_focused_unchecked().wins.focus; 322 + if !on_left { 323 + self.cols.focus_up(); 324 + } 325 + self.cols.focus.wins.insert(win); 326 + } else { 327 + let win = self.cols.focus.wins.remove_focused_unchecked(); 328 + self.cols.focus_up(); 329 + self.cols.focus.wins.insert(win); 330 + } |
Lint the codebase with clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Lint the codebase with clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/