Update target.py #1750
Open
Update target.py #1750
+39
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed variable names to follow snake_case naming convention Removed unnecessary comments Simplified the validation for targetType and targetValue by using the if not statement Merged the getAddresses function and added the validation for IPV6_ADDRESS Merged the getNames function
|
There's a lot happening in this commit and it's not clear what is being changed or why. The code comments are intentional and should remain. It appears the Any changes to the classes also require changes to the associated unit and integration tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed variable names to follow snake_case naming convention Removed unnecessary comments
Simplified the validation for targetType and targetValue by using the if not statement Merged the getAddresses function and added the validation for IPV6_ADDRESS Merged the getNames function