Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docu: additional build local doc shell script working for Mac OS X #637

Closed
wants to merge 1 commit into from

Conversation

onkelandy
Copy link
Member

No description provided.

@msinn
Copy link
Member

msinn commented Mar 31, 2024

What is the difference to the existing script? Could the difference be integrated in the existing script? It would be easier to maintain.

@onkelandy
Copy link
Member Author

onkelandy commented Apr 1, 2024

I have replaced all occurrences of if [ "${DOC,,}" == "all" ]; then and similar by if [ "$(echo "$DOC" | tr '[:upper:]' '[:lower:]')" == "all" ]; then

I've tested the new osx version on debian bookworm and it seems to work fine with the new code. So actually we could replace the original file if tests run smoothly for you, too..?

Morg mentioned that a cleanup might be a good idea as logics such as
GIT_CHECKOUT=False
if [...]; then
GIT_CHECKOUT=False
fi

are not clear or maybe not necessary..? Furthermore there is still a check for doc-develop and doc-user what is not necessary anymore.

@onkelandy
Copy link
Member Author

Möchte jemand das Skript noch testen? Ich würde dann den PR schließen und einen neuen auf das normale build_doc_local stellen. Bei mir klappt das Skript sowohl unter Mac OSX als auch Debian.

@bmxp
Copy link
Member

bmxp commented May 26, 2024

Wenn Du das integriert hast, lasse ich das mal mit meinen neueren Version von Sphinx & Co. laufen. Die neuen Sphinx Versionen haben wohl einige Bugfixes gehabt aber ich bin mir nicht wirklich sicher, ob wir alleine deshalb aktualisieren sollten.

@onkelandy onkelandy closed this May 29, 2024
@onkelandy onkelandy deleted the doc branch May 29, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants