Skip to content

Tt 171 separate dl ds comp #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
@page
@model Smart.Design.Library.Showcase.Pages.Components._ComponentsIndex.ComponentsIndexModel
@{
ViewData["Title"] = "Components documentation";
}

<div class="u-padding-bottom-l">
<h1 class="c-d-h2">@ViewData["Title"]</h1>
</div>

<div class="o-grid">
@await Html.PartialAsync("Shared/_ComponentList")
<div class="o-grid-col-bp3-9">
<div class="br-componentgroup-header-wrapper">
</div>
<div class="br-content c-content u-spacer">
<div class="title u-spacer">
<h2 class="c-h2">Comment documenter un composant ?</h2>
</div>
<div class="o-flex dynamic-dashboard--grid">
<div class="u-spacer">
<h3 class="c-h3">Si celui ci n’est pas un composant C#</h3>
<ol>
<li>Déplacer la page du composant du dossier <code>04_todo</code> vers le dossier <code>03_cat_ds</code></li>
<li>Copier/coller* le code HTML de la page correspondante sur le site du design system: https://design.smart.coop/ en inspectant la page dans la console</li>
<li>Retirer le code pug.</li>
<li>Remplacer le titre dans la variable <code>ViewData["ComponentTitle"]</code></li>
</ol>
<p class="c-body-2">*Lors du copié/collé, attention à bien respecter l’indentation des balises pour ne pas casser la mise en page</p>

</div>
<div class="u-spacer">
<h3 class="c-h3">Si celui ci est un composant C#</h3>
<ol>
<li>Déplacer la page du composant du dossier <code>04_todo</code> vers le dossier <code>02_cat_dl</code></li>
<li>Copier/coller* le code HTML de la page correspondante sur le site du design system: https://design.smart.coop/ en inspectant la page dans la console</li>
<li>Retirer le code pug.</li>
<li>Vérifier si chaque variante du composant à bien été intégrée dans le composant DL. Si ce n'est pas le cas, insérer un warning de ce type:</li>
<p class="br-sample-documentation c-content c-menu__item--danger">This is not well implemented</p>
<p>Si le composant est incomplet, ajouter: <code><p><b>Status:</b> Incomplete</p></code></p>
<li>Documenter l'utilisation du composant DL. Ex: @("<smart-button label=\"Button Label\"></smart-button>")</li>
<li>Remplacer le titre dans la variable <code>ViewData["ComponentTitle"]</code></li>
</ol>
<p class="c-body-2">*Lors du copié/collé, attention à bien respecter l’indentation des balises pour ne pas casser la mise en page</p>
</div>
</div>





</div>
</div>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
</div>
<div class="br-content c-content">
<p class="u-text-danger">195 icons in DS. Only 78 in DL</p>

<p>
The SVG icon system is based on directly embedding SVG files into the markup. Within Bedrock, we use Pug to render these SVG's instead of having to inline them. You can either inline them, or build a solution that does it for you.

Expand Down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le javascript pour TableOfContent ne fonctionne plus

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je check ça et je fais un push. Merci.

Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<div class="o-grid">
@await Html.PartialAsync("Shared/_ComponentList")
<div class="o-grid-col-bp3-9">
<div class="o-grid-col-bp3-9 c-content">
<div class="br-componentgroup-header-wrapper">
<h1 class="br-componentgroup-header c-d-h2">@ViewData["ComponentTitle"]</h1>
<p><b>Status:</b> Complete</p>
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@model Smart.Design.Library.Showcase.Pages.Components.BaseSmartFormGroup.BaseSmartFormGroup
@{
ViewData["MainTitle"] = "Components documentation";
ViewData["ComponentTitle"] = "Form group";
ViewData["ComponentTitle"] = "Base Smart Form group";
}

<div class="u-padding-bottom-l">
Expand Down

This file was deleted.

This file was deleted.

Loading