-
Notifications
You must be signed in to change notification settings - Fork 3
Tt 171 separate dl ds comp #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcelpirnay
wants to merge
7
commits into
main
Choose a base branch
from
TT-171-separate-dl-ds-comp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bb01efd
adding css from DS
marcelpirnay 9bf84da
Adding HTML (only) from DS Components doc
marcelpirnay cee5829
Adding component documentation from DS
marcelpirnay a947422
Remove badges for cleanup
marcelpirnay 56491fa
reordering by categories
marcelpirnay 82ca8cb
Adding "how to document" to the index page
marcelpirnay c775592
doc
marcelpirnay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
54 changes: 54 additions & 0 deletions
54
...Library.Showcase.WebApp/Pages/Components/00_index/_ComponentsIndex/ComponentsIndex.cshtml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
@page | ||
@model Smart.Design.Library.Showcase.Pages.Components._ComponentsIndex.ComponentsIndexModel | ||
@{ | ||
ViewData["Title"] = "Components documentation"; | ||
} | ||
|
||
<div class="u-padding-bottom-l"> | ||
<h1 class="c-d-h2">@ViewData["Title"]</h1> | ||
</div> | ||
|
||
<div class="o-grid"> | ||
@await Html.PartialAsync("Shared/_ComponentList") | ||
<div class="o-grid-col-bp3-9"> | ||
<div class="br-componentgroup-header-wrapper"> | ||
</div> | ||
<div class="br-content c-content u-spacer"> | ||
<div class="title u-spacer"> | ||
<h2 class="c-h2">Comment documenter un composant ?</h2> | ||
</div> | ||
<div class="o-flex dynamic-dashboard--grid"> | ||
<div class="u-spacer"> | ||
<h3 class="c-h3">Si celui ci n’est pas un composant C#</h3> | ||
<ol> | ||
<li>Déplacer la page du composant du dossier <code>04_todo</code> vers le dossier <code>03_cat_ds</code></li> | ||
<li>Copier/coller* le code HTML de la page correspondante sur le site du design system: https://design.smart.coop/ en inspectant la page dans la console</li> | ||
<li>Retirer le code pug.</li> | ||
<li>Remplacer le titre dans la variable <code>ViewData["ComponentTitle"]</code></li> | ||
</ol> | ||
<p class="c-body-2">*Lors du copié/collé, attention à bien respecter l’indentation des balises pour ne pas casser la mise en page</p> | ||
|
||
</div> | ||
<div class="u-spacer"> | ||
<h3 class="c-h3">Si celui ci est un composant C#</h3> | ||
<ol> | ||
<li>Déplacer la page du composant du dossier <code>04_todo</code> vers le dossier <code>02_cat_dl</code></li> | ||
<li>Copier/coller* le code HTML de la page correspondante sur le site du design system: https://design.smart.coop/ en inspectant la page dans la console</li> | ||
<li>Retirer le code pug.</li> | ||
<li>Vérifier si chaque variante du composant à bien été intégrée dans le composant DL. Si ce n'est pas le cas, insérer un warning de ce type:</li> | ||
<p class="br-sample-documentation c-content c-menu__item--danger">This is not well implemented</p> | ||
<p>Si le composant est incomplet, ajouter: <code><p><b>Status:</b> Incomplete</p></code></p> | ||
<li>Documenter l'utilisation du composant DL. Ex: @("<smart-button label=\"Button Label\"></smart-button>")</li> | ||
<li>Remplacer le titre dans la variable <code>ViewData["ComponentTitle"]</code></li> | ||
</ol> | ||
<p class="c-body-2">*Lors du copié/collé, attention à bien respecter l’indentation des balises pour ne pas casser la mise en page</p> | ||
</div> | ||
</div> | ||
|
||
|
||
|
||
|
||
|
||
</div> | ||
</div> | ||
</div> |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
206 changes: 206 additions & 0 deletions
206
src/Smart.Design.Library.Showcase.WebApp/Pages/Components/03_cat_ds/Tooltip/Tooltip.cshtml
Large diffs are not rendered by default.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
35 changes: 0 additions & 35 deletions
35
src/Smart.Design.Library.Showcase.WebApp/Pages/Components/Tooltip/Tooltip.cshtml
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
...t.Design.Library.Showcase.WebApp/Pages/Components/_ComponentsIndex/ComponentsIndex.cshtml
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le javascript pour TableOfContent ne fonctionne plus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je check ça et je fais un push. Merci.