3 ability to update data from UI #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Drane, Lance <[email protected]>
Signed-off-by: Drane, Lance <[email protected]>
Signed-off-by: Drane, Lance <[email protected]>
Signed-off-by: Drane, Lance <[email protected]>
Signed-off-by: Drane, Lance <[email protected]>
…le logs Signed-off-by: Drane, Lance <[email protected]>
Signed-off-by: Drane, Lance <[email protected]>
Signed-off-by: Drane, Lance <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
Currently, when running the latest version of the service-catalog. There's an issue in the backend (I think when converting the jsonld to a model, but could be wrong), however I don't think that it's an issue with the frontend code.
The only other quirk is that I had to use a work around in
Detail.tsxstarting in line 118 inselectedDataseries. That getter would only return one of the x or y axes and it would cause an error. As a quick fix, I just added to the other axis to the final result. I'm going to look at cleaning that up.