Skip to content

Add wire subject test coverage #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

psiman-wandera
Copy link
Contributor

Adding test coverage for new Wire Subject related methods. This improves the overall test coverage of critical parts of the order.Finalize method

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Oct 21, 2024
@psiman-wandera
Copy link
Contributor Author

Hi @hslatman, @beltram , @stefanwire - would you be so kind and have a look at this test coverage of methods related to Wire Subject you were working on lately? Thanks

@hslatman hslatman self-assigned this Oct 29, 2024
@psiman-wandera psiman-wandera force-pushed the wire_subject_test_coverage branch from f99dbd5 to 21ddfbb Compare March 28, 2025 14:37
@psiman-wandera
Copy link
Contributor Author

@1nkfreax can you please re-approval. I've just rebased the branch. Sorry for long delay.

@hslatman hslatman added this to the v0.28.4 milestone Mar 28, 2025
@psiman-wandera psiman-wandera requested a review from 1nkfreax March 31, 2025 12:26
@psiman-wandera psiman-wandera force-pushed the wire_subject_test_coverage branch from 21ddfbb to 44f505c Compare April 2, 2025 14:32
@hslatman
Copy link
Member

hslatman commented Apr 3, 2025

Test failure is unrelated. Fixing in #2235.

@hslatman hslatman merged commit 534e049 into smallstep:master Apr 3, 2025
10 of 12 checks passed
@hslatman
Copy link
Member

hslatman commented Apr 3, 2025

Thank you, @psiman-wandera! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants