-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileSearchView for type=File search #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @shannonehmsen will likely provide better feedback on the styles, but just wanted to point out the border in the common properties section.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - we can remove the common properties panel & remove the "Create New" button for users who aren't admins! One small styling - in the file column, the info button for the file name pop over is the wrong color. This is the hex for the right color. color: #657b95; Thanks!
This pull request includes several changes to improve the
BrowseView
and introduce a newFileSearchView
component. The most important changes include refactoring theBrowseView
, adding a newFileSearchView
component, and updating theContentRenderer
to handle specific view associations.Refactoring and improvements to
BrowseView
:filterFacet
andtransformedFacets
fromBrowseViewBody
and replaced their usage with the importedtransformedFacets
function. [1] [2]isCaseSearch
. [1] [2]createBrowseColumnExtensionMap
function to manage column extensions for the browse view file tables. [1] [2]Introduction of
FileSearchView
component:FileSearchView
component to handle file searches with selected files checkboxes, including the necessary imports and memoized functions for performance optimization.FileTableWithSelectedFilesCheckboxes
component withinFileSearchView
to manage the display and interactions of file search results.Updates to
ContentRenderer
:ContentRenderer
to associate/browse/
searches withBrowseView
instead ofFileSearchView
by manipulating thecontext['@type']
array.