Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSearchView for type=File search #351

Merged
merged 14 commits into from
Feb 25, 2025
Merged

FileSearchView for type=File search #351

merged 14 commits into from
Feb 25, 2025

Conversation

utku-ozturk
Copy link
Collaborator

This pull request includes several changes to improve the BrowseView and introduce a new FileSearchView component. The most important changes include refactoring the BrowseView, adding a new FileSearchView component, and updating the ContentRenderer to handle specific view associations.

Refactoring and improvements to BrowseView:

  • Removed static methods filterFacet and transformedFacets from BrowseViewBody and replaced their usage with the imported transformedFacets function. [1] [2]
  • Simplified the properties passed to components by removing unnecessary properties like isCaseSearch. [1] [2]
  • Added a new createBrowseColumnExtensionMap function to manage column extensions for the browse view file tables. [1] [2]

Introduction of FileSearchView component:

  • Added a new FileSearchView component to handle file searches with selected files checkboxes, including the necessary imports and memoized functions for performance optimization.
  • Included the FileTableWithSelectedFilesCheckboxes component within FileSearchView to manage the display and interactions of file search results.

Updates to ContentRenderer:

  • Modified the ContentRenderer to associate /browse/ searches with BrowseView instead of FileSearchView by manipulating the context['@type'] array.
Screenshot 2025-02-20 at 10 42 21

@utku-ozturk
Copy link
Collaborator Author

Copy link
Collaborator

@crfmc crfmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @shannonehmsen will likely provide better feedback on the styles, but just wanted to point out the border in the common properties section.

Screenshot 2025-02-24 at 11 42 05 AM

Copy link

@shannonehmsen shannonehmsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - we can remove the common properties panel & remove the "Create New" button for users who aren't admins! One small styling - in the file column, the info button for the file name pop over is the wrong color. This is the hex for the right color. color: #657b95; Thanks!

@utku-ozturk utku-ozturk removed the request for review from Bianca-Morris February 25, 2025 20:57
@utku-ozturk utku-ozturk merged commit e428d18 into main Feb 25, 2025
2 checks passed
@utku-ozturk utku-ozturk deleted the utk_file_search_view branch February 25, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants