Skip to content

Conversation

@rtrvrtg
Copy link
Collaborator

@rtrvrtg rtrvrtg commented Jun 11, 2025

AM-272

WIP do not merge

  • Add GitHub Actions PR workflow
  • Snyk tests
  • Rubocop linting
    • Updated Rubocop
    • Adjusted development Dockerfiles so we could upgrade Ruby Gems without having a (completely) nightmarish time
    • Copied Rubocop style rules from https://github.com/reinteractive/reinteractive-style
    • Lots and lots of style errors. Are we sure we want to fix them all up in this pass?
  • RSpec tests
    • Run against Postgres DB in GitHub Actions
    • Only a few errors
  • Downgraded Postgres for local dev env to 16

@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 02:23
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 02:23
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 02:36
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 02:36
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 02:40
@rtrvrtg rtrvrtg changed the title [AM-272] Add GH Actions workflow, Snyk test [AM-272] WIP Add GH Actions workflow, Snyk test Jun 11, 2025
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 02:46
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 02:47
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 02:54
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 02:54
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 03:01
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 03:01
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 03:03
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 03:04
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 07:54
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 07:54
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 07:59
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 07:59
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 08:01
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 08:01
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 08:09
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 08:09
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 08:12
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 08:12
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 08:12
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 08:12
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 08:16
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 08:18
@rtrvrtg rtrvrtg marked this pull request as draft June 11, 2025 08:25
@rtrvrtg rtrvrtg marked this pull request as ready for review June 11, 2025 08:25
@github-actions
Copy link

😰 RSpec failure

265 examples, 7 failures, 1 pending
Example Description Message
spec/features/admin/summary_spec.rb:55 Summary Page the Summary page as an admin with collections and institutions when selecting a start_date filters the stats by date expected to find text "Total duration of items: 01h 06m 28s" in "Select top open navigation Dashboard User CMS Analytics Institutions Reports Pages Themes Site Alerts Site Config User Guide...
spec/features/admin/transcript_spec.rb:18 Transcript Page upload an audio file as an admin shows the summary page undefined method `[]' for nil:NilClass
spec/models/transcript_line_spec.rb:82 TranscriptLine#recalculate when verifying with 2 min_lines_for_consensus third selection should make the line as completed expected: "second" got: "first" (compared using ==)
spec/models/transcript_line_spec.rb:189 TranscriptLine scopes #fuzzy_search when searching with jenna returns expected collection contained: [#<TranscriptLine id: 29, transcript_id: 80, start_time: 2980, end_time: 6850, speaker_id: 0, origina...854363000 +0000", updated_at: "2025-06-11 08:27:52.854363000 +00...
spec/features/transcripts/transcripts_list_spec.rb:25 Transcripts List transcripts list page with transcripts on page shows the transcript img expected to find text "/collections_v2/bkr7qf8wc2/images/591454d3-ca44-44fc-ae82-7e7feb6f2636.jpg" in "http://127.0.0.1:33185/collections_v2/bkr7qf8wc2/images/medium_591454d3-ca44-44fc-ae82-7e7feb6f26...
spec/features/transcripts/transcripts_list_spec.rb:42 Transcripts List transcripts list page when collection has default image shows the collection img expected to find text "/collections_v2/y4io9wuk0c/images/a8422aa6-a958-4ad1-b2e1-e9c2e8ef6b89.jpg" in ""
spec/jobs/azure/speech_to_text_job_spec.rb:17 Azure::SpeechToTextJob#recognize returns the lines expected: "completed" got: "failed" (compared using ==)

@github-actions
Copy link

Slowest examples

Top 10 slowest examples (50.37 seconds, 65.79% of total time)
Example Description Time in seconds
spec/features/admin/summary_spec.rb:45 Summary Page the Summary page as an admin with collections and institutions viewing all stats shows all stats on the page 25.92796
spec/services/voice_base/import_srt_transcripts_spec.rb:71 VoiceBase::ImportSrtTranscripts.call is expected to change transcript_ext.reload.transcript_lines.count from 0 to 3 2.8643
spec/services/voice_base/import_srt_transcripts_spec.rb:69 VoiceBase::ImportSrtTranscripts.call is expected to change transcript.reload.transcript_retrieved_at from nil to an instance of ActiveSupport::TimeWithZone 2.85785
spec/services/voice_base/import_srt_transcripts_spec.rb:72 VoiceBase::ImportSrtTranscripts.call is expected to change transcript_ext.reload.lines from 0 to 3 2.70436
spec/services/voice_base/import_srt_transcripts_spec.rb:65 VoiceBase::ImportSrtTranscripts.call is expected to change transcript.reload.transcript_lines.count from 0 to 432 2.69395
spec/services/voice_base/import_srt_transcripts_spec.rb:86 VoiceBase::ImportSrtTranscripts.call creates transcript lines from a carrierwave source 2.67523
spec/services/voice_base/import_srt_transcripts_spec.rb:67 VoiceBase::ImportSrtTranscripts.call is expected to change transcript.reload.transcript_status.try(:name) from nil to "transcript_downloaded" 2.67129
spec/services/voice_base/import_srt_transcripts_spec.rb:73 VoiceBase::ImportSrtTranscripts.call is expected to change transcript_ext.reload.transcript_status.try(:name) from nil to "transcript_downloaded" 2.66743
spec/services/voice_base/import_srt_transcripts_spec.rb:66 VoiceBase::ImportSrtTranscripts.call is expected to change transcript.reload.lines from 0 to 432 2.66658
spec/services/voice_base/import_srt_transcripts_spec.rb:68 VoiceBase::ImportSrtTranscripts.call is expected to change transcript.reload.duration from 0 to 1883 2.64347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant