Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elixir] Update syntax #13

Merged
merged 1 commit into from
Jul 29, 2021
Merged

[Elixir] Update syntax #13

merged 1 commit into from
Jul 29, 2021

Conversation

hkrutzer
Copy link

  • My commit messages start with the package name in square brackets, e.g. [XML].
  • I have included new or enhanced syntax tests to cover the changes.
  • I have included a performance comparison below:

Performance

Before changes

Syntax "Packages/PackageName/lang.sublime-syntax" took an average of 10.0ms over 10 runs
Syntax "Packages/PackageName/lang-types.sublime-syntax" took an average of 2.0ms over 10 runs

After changes

Syntax "Packages/PackageName/lang.sublime-syntax" took an average of 10.2ms over 10 runs
Syntax "Packages/PackageName/lang-types.sublime-syntax" took an average of 2.0ms over 10 runs

@hkrutzer hkrutzer marked this pull request as draft July 26, 2021 14:30
Copy link
Owner

@slimsag slimsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I'll merge this now, and it will go live on Sourcegraph.com later today and in the next version of Sourcegraph on Aug 20th (v3.31)

@slimsag slimsag marked this pull request as ready for review July 29, 2021 20:17
@slimsag slimsag merged commit 2d1058f into slimsag:master Jul 29, 2021
@slimsag
Copy link
Owner

slimsag commented Jul 29, 2021

Ah, unfortunately I've had to back this change out - I just realized the updated syntax uses Sublime Text 4 features (sublime-syntax v2) which the Rust syntax highlighter, Syntect, doesn't support yet: trishume/syntect#323

slimsag added a commit that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants