Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a suffix to the name of inferior lisp buffers #748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galdor
Copy link
Contributor

@galdor galdor commented Jan 12, 2023

In the current state, SLIME names all inferior lisp buffers *inferior-lisp* by default. When starting multiple implementations, we end up with multiple inferior lisp buffers whose only difference is a non-descriptive number suffix.

With this patch, we use the name of the implementation as suffix, in a way similar to REPL buffers.

For example with two inferior lisps SBCL and CCL, we now have *inferior-lisp sbcl* and *inferior-lisp ccl*

We also name comint processes the same way, but with a dash since there are no "*" characters around to delimit the name.

In the current state, SLIME names all inferior lisp buffers `*inferior-lisp*`
by default. When starting multiple implementations, we end up with multiple
inferior lisp buffers whose only difference is a non-descriptive number
suffix.

With this patch, we use the name of the implementation as suffix, in a way
similar to REPL buffers.

For example with two inferior lisps SBCL and CCL, we now have `*inferior-lisp
sbcl*` and `*inferior-lisp ccl*`

We also name comint processes the same way, but with a dash since there are no
"*" characters around to delimit the name.
@galdor
Copy link
Contributor Author

galdor commented Jan 23, 2023

Could someone have a look and merge the patch if it is ok? It really helps when you are have multiple connections open (e.g. when checking code against multiple implementations).

@luismbo
Copy link
Member

luismbo commented Jan 25, 2023

There's a concept of connection name (the :name argument to slime-start IIRC). Perhaps it'd be better to use that.

@galdor
Copy link
Contributor Author

galdor commented Jan 25, 2023

You mean use what was passed with :name instead of using the name of the implementation? I can't seem to find how :name is usually being passed when running slime, is it even set somewhere?

@luismbo
Copy link
Member

luismbo commented Jan 25, 2023

Yes, I think it's only possible to set it via slime-start. Perhaps the slime command should provide a better default: the implementation name, as you suggest. (Another option would be to use the core/image name, perhaps without file type.) The name needs to be passed down to slime-start-lisp too, since there's no slime-connection-name at that point yet.

@galdor
Copy link
Contributor Author

galdor commented Jan 25, 2023

Yes it could make sense. I'll rework this patch when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants