[Serve] [Example] Multi-node example #3398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Thanks for adding the multi-node support @MaoZiming ! Left some comments. Also, it will be great to add a smoke test to show that multi-node is gang scheduling (maybe manually terminate one of them and see the serve controller's behaviour)
| cloud: gcp | ||
| ports: 8000 | ||
| accelerators: A100:2 | ||
| use_spot: true |
There was a problem hiding this comment.
if we are using spot, maybe we should add a comment saying the multi-node is gang scheduling? actually I'm not sure if we should use spot here. cc @Michaelvll for a look
There was a problem hiding this comment.
Both spot and non-spot should be gang-scheduled
There was a problem hiding this comment.
Yeah, just want to say that spot is more error-prone
There was a problem hiding this comment.
sg, added a comment at the first line
MaoZiming
force-pushed
the
multi-node-example
branch
from
fb56291
to
1a798dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a YAML example for multi-node serving Llama-2-70b-hf, on 2 node A100:2.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh