-
Notifications
You must be signed in to change notification settings - Fork 0
Force approve tokens in CCTP relayer #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thal0x
wants to merge
55
commits into
axelar_execute_swap
Choose a base branch
from
jw/cctp-force-approve
base: axelar_execute_swap
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axelar execute swap
[API-3529] Implement GoFastHandler contract
additional changes
use forceApprove instead of safeApprove
emit events on swap success
…r and also emit the fee recipient
fix lombard spend and modify transfer event
implement eureka handler
update lombardTransfer to use minAmountOut parameter
emit lbtc voucher denom in lombard transfer function
fix relay fee transfer in swap + transfer
use safe transfer
support native eth in swapAndTransfer
Use forceApprove
support native tokens in EurekaHandler.transfer
7e34f83
to
3677bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates token approvals in CCTP relayer to use the
SafeERC20.forceApprove
function in order to work with USDT. We we.safeApprove
in the Axelar contract however it looks like that has been deprecated and forceApprove effectively does the same thing.