Some extra changes for D9. #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andypost
requested changes
Jul 30, 2020
| * The event to process. | ||
| */ | ||
| public function onKernelTerminate(PostResponseEvent $event) { | ||
| public function onKernelTerminate(TerminateEvent $event) { |
There was a problem hiding this comment.
Please file separate issue for that, also it needs link to change record where the event was renamed
| */ | ||
| protected function entityTypeHasBundles($entity_type_id) { | ||
| $entity_type = $this->entityManager->getDefinition($entity_type_id); | ||
| $entity_type = $this->entityTypeManager->getDefinition($entity_type_id); |
There was a problem hiding this comment.
Entity manager addressed in d9-fixes branch where I did split commits on per d-org issue
There was a problem hiding this comment.
Basically rename of the variable is useless at the moment
| $message = ($status == SAVED_UPDATED) ? '%label event type updated.' : '%label event type added.'; | ||
| $url = $event_type->toUrl(); | ||
| $t_args = ['%label' => $event_type->id(), 'link' => Link::fromTextAndUrl(t('Edit'), $url)]; | ||
| $t_args = ['%label' => $event_type->id(), 'link' => (Link::fromTextAndUrl($this->t('Edit'), $url))->toString()]; |
There was a problem hiding this comment.
Good catch, also it needs separate issue (probably it exists)
Moreover it needs to rework messages as they are not translatable yet
There was a problem hiding this comment.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.