Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where other heading levels are disabled when Heading 1 is selected #222

Merged
merged 3 commits into from
May 22, 2024

Conversation

Keito654
Copy link
Contributor

Fix issue #197

I have modified the code by moving the variableleveloutside the scope of the if statement and renamed it to currentLevel for greater specificity. Additionally, I have included currentLevel in the conditions for canSetHeading.

Please excuse any oversights as I am new to contributing and still familiarizing myself with the process.

Copy link
Owner

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this! I'll aim to test this later, but generally looks good to me!

src/controls/MenuSelectHeading.tsx Show resolved Hide resolved
@sjdemartini sjdemartini merged commit ad613a7 into sjdemartini:main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants