Wikidata assumption leads to bad data #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an assumption that if there is no matching wikipedia link that label is safe to use when querying wikidata. It is not.
Human Tetris. It is only (currently) available on de and nl wikipedia. But it takes the 'Human Tetris' label, applies it to en.wikipedia, and ends up pulling the info for Human Tetris which redirects to Brain Wall. Completely wrong which corrupts any data being read, for example, the text extract.
With this change, if there is no matching language match when using wikidata:
a) Title is not set
b) Queries that depend upon the title do not happen