feat: default to POST instead of GET when body is given #73
+29
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #72. |
|
Although it is not common for GET requests to have a request body, it should be considered permissible. |
|
LGTM |
Alright, then the currently suggested implementation should match that. Just double checked, should be fine. Just noticed the help string of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure checking whether
methodhas actually been set might be too much - usingGETwith a body probably never makes sense, so one could probably also set it toPOSTeven ifGEThas been set explicitly? 🤔On the other hand, this also covers the case of a user explicitly using another, legit, method.