feat(badge): Badge 컴포넌트 구현 #30
Conversation
noahluftyang
requested review from
kimdaeyeobbb,
hy57in,
developerjhp,
bae-sh,
froggy1014,
heeji289 and
synuns
as code owners
🦋 Changeset detectedLatest commit: 71bf2b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
noahluftyang
force-pushed
the
feat/badge
branch
2 times, most recently
from
c7c2ca3 to
f8eb721
Compare
noahluftyang
force-pushed
the
feat/badge
branch
from
f8eb721 to
57a0fb9
Compare
| "dev:storybook": "storybook dev -p 6006", | ||
| "lint": "biome lint .", | ||
| "test": "vitest", | ||
| "typecheck": "tsc", |
There was a problem hiding this comment.
히딩크 모드 도입
coverage script도 추가해야하지 않아?
나중에 CodeCov 넣는다길래
"test:coverage": "vitest run --coverage",
There was a problem hiding this comment.
커버리지는 모노레포 루트에서 일괄 실행하는걸로 생각 중인데, 실제 셋팅하면서 어떻게 할지 정해볼게!
| coverage: { | ||
| include: ['./src/**/*.{ts,tsx}'], | ||
| exclude: ['./src/**/*.stories.tsx', './src/env.d.ts', './src/index.ts'], | ||
| }, |
There was a problem hiding this comment.
coverage 돌리니까 아무것도 실행안되길래, 찾아보니까
vitest는 glob pattern이라서 ./ 지워져야 되더라
coverage: {
enabled: true,
reporter: ['text', 'json', 'html'],
include: ['src/*.{ts,tsx}'],
exclude: [
'src/**/*.test.{ts,tsx}',
'src/*.stories.{ts,tsx}',
'src/*.d.ts',
'src/index.ts',
],
all: true,
},
```| > | ||
| <Typography | ||
| asChild={true} | ||
| color="#00FFFF" |
There was a problem hiding this comment.
children에 문자열을 넣으면 반드시 teal 색상이고,
만약 이 뱃지에만 다른 색상의 문자열을 넣고 싶다면 <Element>로 넘겨줘야하는거야 ~ ?
There was a problem hiding this comment.
우선은 색상 가이드가 안정해져서 teal 고정으로 구현했고 추후에 가이드 확장하면 다양한 색상 지원할 수 있을 것 같아~
변경사항
시각자료
체크리스트
추가 논의사항