-
Notifications
You must be signed in to change notification settings - Fork 84
Optimize queries for participants_data view #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this file, we already have similar script in https://github.com/sio2project/oioioi/blob/master/oioioi/oi/management/commands/import_schools_legacy.py
except Contest.DoesNotExist: | ||
raise CommandError(_("Contest %s does not exist") % options['contest_id']) | ||
|
||
# rcontroller = contest.controller.registration_controller() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change name in such a way that it is clear that this is dev only script and it creates random data dev_generate_random_oi_participants.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can skip this script (and remove it from this PR).
You can remove participants either by clearing the whole database (in dev environment)
or you could run the same command from django shell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please handle the comments from the review.
Closes #345