Migrate Notifications server to python #198 #526
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iteron-dev
requested changes
Jun 7, 2025
| response.raise_for_status() | ||
| result = await response.json() | ||
|
|
||
| if result.get('status') != 'OK': |
There was a problem hiding this comment.
I'm not sure this is a good idea. Since we're using HTTP, the client should rely on appropriate status codes - for example, 401 (Unauthorized). Instead of checking a JSON field, we should check the status code, especially since those fields can be somewhat opaque. Therefore, refactoring views.py would be a good idea.
There was a problem hiding this comment.
I agree with you. I wanted only to rewrite the node.js server without changing anything else, but assuming that no one else uses this endpoint it should be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated the server. Used socketify.py for high performance WebSockets. The server configuration variables and deployment remain the same. Additionally the server is now tested using the normal Django test suite.