-
Notifications
You must be signed in to change notification settings - Fork 85
Django 5 migration #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Django 5 migration #483
Conversation
… in test_invalidated_user_logout
d0d121a
to
9870e92
Compare
…ngo deprecation)
…isted by `django-upgrade` tool)
…ango-nested-admin` to `>=4.1,<4.2`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions (in context of upgrading sio2.mimuw to Django 5):
- why are some migrations changed? Is it possible to do this automatically?
- should in every admin
.short_description
be replaced with@admin.display(description=...)
?
from django.urls import re_path | ||
|
||
from oioioi.workers import views | ||
|
||
app_name = 'workers' | ||
|
||
urlpatterns = [ | ||
re_path(r'^workers/$', views.show_info_about_workers, name='show_workers'), | ||
path('workers/', views.show_info_about_workers, name='show_workers'), | ||
re_path(r'^workers/load.json$', views.get_load_json, name='get_load_json'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this re_path
is not changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was automatically made by django-upgrade. I could change the remaining re_path
to path
manually if needed.
@@ -0,0 +1,23 @@ | |||
# Generated by Django 4.2.20 on 2025-04-15 22:08 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MasloMaslane This is the biggest concern in the migration to Django 5.2.
Due to change of index handling we need to fix the names of the indexes
(see https://adamj.eu/tech/2020/07/27/how-to-modernize-your-django-index-definitions/)
Default migration method requires long downtime due to rebuilding of the indexes, this suppose to be zero-downtime method, but we need to make sure that the "old_names" are correct.
It's a similar situation to |
Resolve #453.