-
Notifications
You must be signed in to change notification settings - Fork 84
Add a simple oauth implementation via django-oauth-toolkit #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gkju
wants to merge
19
commits into
sio2project:master
Choose a base branch
from
gkju:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalen
reviewed
May 21, 2025
twalen
reviewed
May 21, 2025
twalen
reviewed
May 21, 2025
twalen
requested changes
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've added minor comments.
…en adding OAuth2 classes instead, refactor two constants
twalen
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding barebones oauth support is pretty trivial when using django-oauth-toolkit and this commit demonstrates the MVP. In a debug environment as per the docs one can use
/o/applications/
to register an oauth2 app with ex;then retrieve an access token for admin (after replacing
<client_id>
,<client_secret>
with the appropriate values) usingcurl
;and authenticate API calls via the access token (using the bearer scheme) which can be refreshed with the refresh token as in the spec. Other oauth2 flows work out of the box as well. In a production environment, I would implement special admin pages for managing the applications, and add config options for enabling oauth/defining clients. The toolkit package also adds some new migrations for the oauth-related models which have to be applied in current installations.
The things to consider are;
This pull request would be very useful for the upcoming TAG semester, in my opinion, as it greatly simplifies creating discrete applications that interconnect with oioioi installations.