Implement IRC31 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the whole specification of IIP-31 (icon-project/IIPs#31)
The Java code and tests stricly follow the same logic than the one in its Python alternative (https://github.com/sink772/multi-token-standard).
I also looked at @jspark-icon's PR (#6) and improved this PR based on it, mostly for RLP encoding. I noticed new useful methods but didn't implement
mintBatchandburnBatchas they didn't match with the IIP-31.There are 2 failing tests,
testOnBatchReceivedandtransferFromBatchbecausenewByteArrayObjectWriterisn't implemented yet injavaee-unittest