[python] Add spatial read to GeometryDataFrame
#3733
+230
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-dark
approved these changes
Feb 25, 2025
| ) | ||
| if region_coord_space is not None: | ||
| raise ValueError( | ||
| "Cannot specify the output coordinate space when region transform i" |
There was a problem hiding this comment.
Suggested change
| "Cannot specify the output coordinate space when region transform i" | |
| "Cannot specify the output coordinate space when region transform " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: sc-52732
Changes:
Coordinate setter utils are now aware of SpatialDataFrame coordinate space. Also domain is expected to be a mapping between axis names and the axis domain for geometry columns.
Notes for Reviewer:
This PR adds spatial reads to
GeometryDataFrame. The spatial ranges per axis are all grouped under the spatial column's name. When setting the coordinate ranges for each dimension the geometry column is identified by the addeddtypemetadata field on the arrow schema field.