Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
Closes #3704
Replaces #3703
XRef conda-forge/tiledbsoma-feedstock#6
Changes:
Fixes the
tiledbsome.io._util._FSPathWrapper
implementation to be compatible with changes in Python3.13
pathlib.Notes for Reviewer:
Since
3.12
it's a lot easier to subclasspathlib.Path
, which is why the version check in the_FSPathWrapper
class is targeting3.12
now. Your previous implementation worked on3.12
but used the current working directory as path for all pathlib operations. (It's not used in the 'hack' within anndata, but just so you're aware).I believe your hack will continue to work with Python
3.14
, if anndata does not start to use more pathlib API features for the provided filename, or refactors theAnnDataFileManager.filename
property.In general, it would be a much better solution to contribute support upstream to anndata to allow reading directly from file-like objects. I'll see if I can find some time to do so.
Also let me know if more changes to the workflow configurations are needed. I just copied from #3703
Cheers,
Andreas 😃