#3560 review #3663
Merged
#3560 review #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkmartinjr
reviewed
Feb 4, 2025
bkmartinjr
approved these changes
Feb 4, 2025
this allows the type system to understand that e.g. the return value of a `.read()` can be a `PyDictLedgerEntry`, which can then have `to_dict()` invoked
ryan-williams
force-pushed
the
rw/3560
branch
from
40c4fa3 to
5e876ab
Compare
Fixed!
Yea, if you merge this, it will update bkm/hypothesis and you can continue working there |
bkmartinjr
added a commit
that referenced
this pull request
Feb 5, 2025
* hypothesis draft * backport to python 3.9 and pandas<2.0 * remove metadata work-arounds * add metadata time travel ledger * add readme * fix numeric overflow in fastercsx test * remove sensitivity to another numeric precision corner case * increase scope of fastercsx coords tested * add string/binary columns to dataframe tests * lint * add enum/dict * disable io * fix padding required for arrow offset testing * remove obsolete comment * fix overflow warning * update readme * lint * remove sc-61239 work-around * remove incomplete test stub * #3560 review (#3663) * factor README link * use `mode: OpenMode` instead of `mode: str` * add missing `self` params * OpenMode * rm unused `SOMAArrayStateMachine._reopen` * `s/work-arounds/workarounds/` * add/tweak type annotations * `get_entries`: return `set[str]` * parameterize `Ledger` with a `LedgerEntryType` this allows the type system to understand that e.g. the return value of a `.read()` can be a `PyDictLedgerEntry`, which can then have `to_dict()` invoked * rm unused `concurrency` fixture * rm unused imports * avoid `st` shadowing --------- Co-authored-by: Ryan Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: stacked on #3560
I chased a few yellow/red squigglies in my editor, and also ran
mypyonapis/python/tests/htand skimmed the issues it flagged (just as an audit;mypyis normally disabled fortests/because it generates too many FPs).Changes:
Added/Tweaked some type annotations, removed a few unused functions, etc.