[c++] Push down PointCloudDataFrame spatial metadata from Python to C++
#3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method allows child classes to write additional metadata to the TileDB array before closing. This also changes the `create`/`_create` method to use standard objects instead of a pointer.
johnkerl
changed the title
PointCloudDataFrame class from Python to C++PointCloudDataFrame spatial metadata from Python to C++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3630 +/- ##
==========================================
+ Coverage 65.07% 65.09% +0.02%
==========================================
Files 151 151
Lines 19695 19481 -214
Branches 1194 1177 -17
==========================================
- Hits 12816 12682 -134
+ Misses 6457 6383 -74
+ Partials 422 416 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: [sc-62101]
Changes:
SOMAArray::_createmethod that passes back the raw TileDB-Array for additional metadata writes in subclasses.PointCloudDataFrameclass.