RequiredDeep
: Fix behaviour with undefined
#1218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217
RequiredDeep
currently removes allundefined
s, soRequiredDeep<{a: string | undefined}>
returns{a: string}
, even thougha
is not optional. But IMO, it should only affect optional properties similar to how the built-inRequired
utility works.If there's a request, we can consider adding an option to remove
undefined
s as well, but that shouldn't be the default behaviour.This PR:
RequiredDeep
to only operate on optional properties.| undefined
attached to them.