New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apps or names cannnot try to open #272
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Basic Info
Windows
System: Windows 10 x64 (19043.1348)
Browser:
MacOS
What is expected?
Steps to reproduce
I wrote the following code in the Windows which is consistent with the description in Basic Info. If the description of app api in the options is correct, then the web page will be opened by the chrome browser because there is no firefox browser. But the current situation is that the chrome browser or the msedge browser does not open the web page.
Then I wrote the similar code that change in the MacOS which is consistent with the description in Basic Info, just replaced
msedge
withsafari
. The browser still does not open the web page.Analysis
After debugging, I think the problem lies in the
pTryEach
function:The
mapper
function calls thebaseOpen
function, and no exception is thrown in thebaseOpen
function, so thecatch
is actually an unreachable statement.After reading the api of child_process in node.js, I think we should refer to options.stdio to modify
childProcessOptions
And add the following code after the statement to throw an exception:
Please confirm whether the bug exists, and I will submit a pr to fix it after confirmation.
The text was updated successfully, but these errors were encountered: