Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: wrangler doesn't open edge when chrome isn't available #1445

Open
threepointone opened this issue Jul 11, 2022 · 4 comments
Open
Labels
blocked Blocked on other work bug Something that isn't working

Comments

@threepointone
Copy link
Contributor

What version of Wrangler are you using?

2.0.16

What operating system are you using?

Mac

Describe the Bug

I have Edge installed. I do not have chrome installed. When I hit d after starting up wrangler dev, the devtools don't open. This is the code that should "work": https://github.com/cloudflare/wrangler2/blob/5b4d5a976a72e65149c883d2dbcb21f2125fc56e/packages/wrangler/src/inspect.ts#L646-L658

@threepointone threepointone added the bug Something that isn't working label Jul 11, 2022
@caass caass self-assigned this Oct 12, 2022
@caass
Copy link
Contributor

caass commented Oct 12, 2022

This seems related to sindresorhus/open#272, and has to do with an internal bug with open. I'll see if I can reproduce in a minimal app and fix.

@caass
Copy link
Contributor

caass commented Oct 12, 2022

Created sindresorhus/open#289, hopefully it's a starting point to resolve the issue

@caass caass added the blocked Blocked on other work label Oct 12, 2022
@caass
Copy link
Contributor

caass commented Nov 29, 2022

After not getting any feedback on sindresorhus/open#289, I'm going to put this back in the backlog

@makepanic
Copy link

makepanic commented Mar 3, 2024

One potential workaround for this would be to support an environment variable that allows the user to specify the requested chrome based browser binary, e.g.:

DEVTOOLS_BROWSER=/usr/bin/chromium wrangler pages dev ...

If this would be ok I can open a PR which adds support for it. That way any new browser or currently unsupported browser can be supported without adjusting the code.
I'm seeing a similar issue here on linux. It tries to open google-chrome which isn't installed but chromium is. With an environment variable i could ignore this and tell wrangler to use the chromium binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on other work bug Something that isn't working
Projects
Status: Other
Development

No branches or pull requests

4 participants