Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm 10 bug with npm pack; issue 740 #743

Merged

Conversation

transitive-bullshit
Copy link
Contributor

@transitive-bullshit transitive-bullshit commented Apr 16, 2024

Fixes #740

Anyone using np with newer versions of Node.js and npm >= 10 is probably running into this issue. This PR just sanitizes the stdout from npm pack to look for the first [ character to start parsing the output JSON array, which should be backwards compatible with previous functionality.

@sindresorhus
Copy link
Owner

Can you open an issue or link to an existing npm issue about this as a code comment? I would like to be able to eventually remove that workaround.

@transitive-bullshit
Copy link
Contributor Author

Looks like this is the corresponding issue to track for npm/cli npm/cli#7354

@sindresorhus
Copy link
Owner

as a code comment

@transitive-bullshit
Copy link
Contributor Author

Ahhh missed that. Done 😃

@voxpelli
Copy link
Contributor

Random sidenote: Reminds the that this would be awesome: sindresorhus/eslint-plugin-unicorn#1858 (comment)

@sindresorhus sindresorhus merged commit 4caa295 into sindresorhus:main Apr 17, 2024
3 checks passed
Vylpes pushed a commit to Vylpes/random-bunny that referenced this pull request Jun 10, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [np](https://github.com/sindresorhus/np) | devDependencies | major | [`^9.0.0` -> `^10.0.0`](https://renovatebot.com/diffs/npm/np/9.2.0/10.0.5) |

---

### Release Notes

<details>
<summary>sindresorhus/np (np)</summary>

### [`v10.0.5`](https://github.com/sindresorhus/np/releases/tag/v10.0.5)

[Compare Source](sindresorhus/np@v10.0.4...v10.0.5)

-   Fix npm 10 compatibility for real ([#&#8203;744](sindresorhus/np#744))  [`34409be`](sindresorhus/np@34409be)

### [`v10.0.4`](https://github.com/sindresorhus/np/releases/tag/v10.0.4)

[Compare Source](sindresorhus/np@v10.0.3...v10.0.4)

-   Fix compatibility with npm 10 ([#&#8203;743](sindresorhus/np#743))  [`4caa295`](sindresorhus/np@4caa295)

### [`v10.0.3`](https://github.com/sindresorhus/np/releases/tag/v10.0.3)

[Compare Source](sindresorhus/np@v10.0.2...v10.0.3)

-   Fix publish OTP for Yarn Berry ([#&#8203;741](sindresorhus/np#741))  [`02f60c7`](sindresorhus/np@02f60c7)

### [`v10.0.2`](https://github.com/sindresorhus/np/releases/tag/v10.0.2)

[Compare Source](sindresorhus/np@v10.0.1...v10.0.2)

-   Use npm for tagging versions when pnpm is the chosen package manager ([#&#8203;739](sindresorhus/np#739))  [`770418f`](sindresorhus/np@770418f)

### [`v10.0.1`](https://github.com/sindresorhus/np/releases/tag/v10.0.1)

[Compare Source](sindresorhus/np@v10.0.0...v10.0.1)

-   Fix compatibility with npm 10 ([#&#8203;737](sindresorhus/np#737))  [`9fdebd5`](sindresorhus/np@9fdebd5)

### [`v10.0.0`](https://github.com/sindresorhus/np/releases/tag/v10.0.0)

[Compare Source](sindresorhus/np@v9.2.0...v10.0.0)

##### Breaking

-   Remove the `--yarn` flag ([#&#8203;730](sindresorhus/np#730))  [`4b3b599`](sindresorhus/np@4b3b599)
    -   The functionality is replaced by `--package-manager`. See below.

##### Improvements

-   Add `--package-manager` flag ([#&#8203;730](sindresorhus/np#730))  [`4b3b599`](sindresorhus/np@4b3b599)
    -   This acts like the [`packageManager` field](https://nodejs.org/api/packages.html#packagemanager) in package.json. `np` will default to reading package.json, and look for lockfiles to determine the best package manager as a last resort.
-   Add pnpm support ([#&#8203;730](sindresorhus/np#730))  [`4b3b599`](sindresorhus/np@4b3b599)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/159
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

np with npm 10.5.1: Failed to parse output of npm pack
3 participants