Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump major version of @types/eslint #57

Conversation

rostislav-simonik
Copy link
Contributor

fxes #56

@sindresorhus
Copy link
Owner

How is it redundant? It's used here:

import type {ESLint, Linter} from 'eslint';

@rostislav-simonik
Copy link
Contributor Author

ok, missed that, could it be in @sindresorhus peer dependencies instead? It isn't really needed for the final artifact, but more for integration in another typescript-based package.

@sindresorhus
Copy link
Owner

Peer dependency would not be correct. It is a dependency of the types and the types are shipped in the package. It's no different from the JS dependencies.

@rostislav-simonik
Copy link
Contributor Author

rostislav-simonik commented Mar 19, 2023 via email

@sindresorhus
Copy link
Owner

Upgrading the dependency.

@rostislav-simonik
Copy link
Contributor Author

rostislav-simonik commented Mar 19, 2023 via email

@rostislav-simonik rostislav-simonik changed the title chore(deps): remove redundant dependency hore(deps): bump version of @types/eslint to major one Mar 19, 2023
@rostislav-simonik rostislav-simonik changed the title hore(deps): bump version of @types/eslint to major one hore(deps): bump major version of @types/eslint Mar 19, 2023
@rostislav-simonik rostislav-simonik changed the title hore(deps): bump major version of @types/eslint chore(deps): bump major version of @types/eslint Mar 19, 2023
@sindresorhus sindresorhus merged commit 7de05cb into sindresorhus:main Mar 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants