fix deepkeys to work with empty arrays and objects

sindresorhus · Mar 3, 2023 · 40f947c · 40f947c
1 parent 7cfa81f
commit 40f947c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -3,6 +3,10 @@ const isObject = value => {
  return value !== null && (type === 'object' || type === 'function');
 };
 
+const isEmptyObject = (value) => {
+ return isObject(value) && Object.entries(value).length === 0;
+};
+
 const disallowedKeys = new Set([
  '__proto__',
  'prototype',
@@ -326,6 +330,10 @@ function * deepKeysIterator(object, currentPath = []) {
 
  for (const [key, value] of entries(object)) {
  yield * deepKeysIterator(value, [...currentPath, key]);
+
+ if (isEmptyObject(value)) {
+ yield key;
+ }
  }
 }
 

diff --git a/test.js b/test.js
@@ -420,6 +420,8 @@ test('deepKeys', t => {
  }],
  e: '🦄',
  f: 0,
+ h: {},
+ i: [],
  },
  '': {
  a: 0,
@@ -437,6 +439,8 @@ test('deepKeys', t => {
  'a\\.b.c.d[2].g',
  'a\\.b.c.e',
  'a\\.b.c.f',
+ 'h',
+ 'i',
  'a\\.b..a',
  '.a',
  ]);