Adopt localized resources #82
Conversation
| @@ -95,9 +95,9 @@ final class SettingsTabViewController: NSViewController, SettingsStyleController | |||
| } else { | |||
| let settings: String | |||
| if #available(macOS 13, *) { | |||
| settings = Localization[.settings] | |||
| settings = NSLocalizedString("settings", bundle: .module, comment: "") | |||
There was a problem hiding this comment.
Still incorrect indentation.
There was a problem hiding this comment.
are you using a different indentation configuration? to align, what are yours?!
There was a problem hiding this comment.
You are asking questions that you can simply check yourself. The existing indentation exists in all the source files.
|
Please use these modern lang tags for Chinese: zh-Hans in lieu of zh-CN. |
|
Closing for lack of activity. Going to leave this for someone else. |
|
@ShikiSuen Could you apply the changes you proposed and open a new PR? |
|
@DivineDominion I'll see whether I can find some time to do this in this month (Jan). |
|
@DivineDominion I'll do this after #90 gets merged, reducing possibilities of merging conflicts. |
As of issue #77 i localized package strings in a Resource Folder exactly as described in Apple documentation.
PS: while I was trying to sync the fork the initial PR was intentionally merged.