Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename project to Settings #76

Closed
sindresorhus opened this issue Jun 8, 2022 · 6 comments
Closed

Rename project to Settings #76

sindresorhus opened this issue Jun 8, 2022 · 6 comments
Assignees

Comments

@sindresorhus
Copy link
Owner

Later this year.

  • While I'm doing that, also rename preferencePaneIdentifier to paneIdentifier and preferencePaneTitle to paneTitle. And the preferencePanes parameter to panes.
@sindresorhus sindresorhus self-assigned this Jun 8, 2022
@ShikiSuen
Copy link
Contributor

Maybe SDSettings is better. General names like "Settings" and "Preferences" can cause serious confilcts with certain names occupied by Apple.

For example: InputMethodKit preference panel (shown in macOS System Preferences / Settings) requires that the target name of the pref pane has to be "Preferences". This causes building conflict with the "sindresorhus / Preferences" package.

dezinezync pushed a commit to dezinezync/Preferences that referenced this issue Dec 17, 2022
dezinezync pushed a commit to dezinezync/Preferences that referenced this issue Dec 17, 2022
@DivineDominion
Copy link
Collaborator

@sindresorhus Looks like there's not much left to do: I spotted that the Sources/ subfolder would need to finally be changed, and applies some renames in #90

Also needs to be changed the window's autosave name:

extension NSWindow.FrameAutosaveName {
	static let settings: NSWindow.FrameAutosaveName = "com.sindresorhus.Preferences.FrameAutosaveName"
}

And the localization strings.

@DivineDominion
Copy link
Collaborator

@ShikiSuen The prefixes usually aren't necessary anymore when you can disambiguate by using Swift module names. Wouldn't this also work for the InputMethodKit problem you described?

@ShikiSuen
Copy link
Contributor

@DivineDominion Sorry, it doesn't work. It stops the project from being compiled.

@ShikiSuen
Copy link
Contributor

@DivineDominion Nevertheless, I see that you are about to rebrand this project to Settings. I believe that this will mitigate this issue for the current version of the InputMethodKit. However, InputMethodKit is subject to further unknown changes.

@sindresorhus
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants